dgb: aux-parent coinbase serialization parity baseline KAT (D0) - #298
Merged
Conversation
Freezes the pre-templating wire image of the shared doge::coin::CMerkleTx (parent-coinbase carrier) so the v36-standardize Scrypt value-type extraction can prove its m_tx type swap is byte-neutral. Asserts the cross-type invariant directly: ltc::coin::MutableTransaction and dgb::coin::MutableTransaction serialize the parent coinbase byte-identically (both extend bitcoin_family::coin::base_transaction). Test-only, fenced to src/impl/dgb/; CONSUMES the shared aux module, modifies nothing. Golden anchored to master HEAD f732061; a later rebase that re-shapes the serializer trips the test rather than silently shifting the golden. 4/4 green. Registered in both test/CMakeLists.txt and the build.yml --target allowlist.
frstrtr
force-pushed
the
dgb/aux-parent-coinbase-parity-baseline
branch
from
June 21, 2026 17:47
26783ea to
2356967
Compare
This was referenced Jun 22, 2026
frstrtr
added a commit
that referenced
this pull request
Jun 23, 2026
…aseline dgb: aux-parent coinbase serialization parity baseline KAT (D0)
frstrtr
added a commit
that referenced
this pull request
Jun 23, 2026
Commit b4126e8 (#271 merge) landed unresolved git conflict markers (<<<<<<< / ======= / >>>>>>>) inside the Build tests --target allowlist at both the Release and ASan+UBSan jobs, breaking the cmake --build line and turning the build.yml workflow red on master since that merge. Both conflict sides are dgb test targets; resolve as the token union: keep dgb_aux_parent_coinbase_parity_test (#298) AND add the dgb_template_capture_test (#271) target. Drift-guard passes (59 targets); YAML parses; diff fenced to .github/workflows/build.yml only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Freezes the pre-templating wire image of the shared
doge::coin::CMerkleTx(the parent-coinbase carrier) as a golden KAT, and asserts the cross-type byte-identity invariant the v36-standardize Scrypt value-type extraction depends on.LtcTypedMemberPayloadGolden— witness-stripped parent coinbase (real member typeltc::coin::MutableTransaction).LtcVsDgbTypeByteIdentical— same canonical coinbase serialized throughltc::coin::MutableTransactionanddgb::coin::MutableTransactionproduces byte-identical witness-stripped bytes. Both extendbitcoin_family::coin::base_transaction; this is exactly what the extraction must preserve when them_txmember type is lifted to a neutral Scrypt-family base.MerkleTxWireGoldenAnchored— fullCMerkleTxwire image, anchored to master HEADf732061bc.MerkleTxRoundTripStable— Unserialize -> reserialize stability.Scope / safety
Test-only, fenced to
src/impl/dgb/. Consumes the shared aux module (src/impl/doge/coin/auxpow.hpp, ltc-doge domain) and modifies nothing. No consensus-value change. Registered in bothsrc/impl/dgb/test/CMakeLists.txtand thebuild.yml--target allowlist (no NOT_BUILT sentinel).Golden anchored to current master HEAD; a later rebase that re-shapes the serializer trips the test rather than silently shifting the golden. No cross-coin serialization divergence observed at the anchor.
4/4 green locally.